Skip site navigation (1) Skip section navigation (2)

Re: uuid patch 2.0 (8.3devel)

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-patches(at)postgresql(dot)org
Cc: Gevik Babakhani <pgdev(at)xs4all(dot)nl>
Subject: Re: uuid patch 2.0 (8.3devel)
Date: 2007-01-25 23:01:58
Message-ID: 200701260001.59726.peter_e@gmx.net (view raw or flat)
Thread:
Lists: pgsql-patches
Gevik Babakhani wrote:
> Hereby the version 2.0 of the uuid datatype patch with modifications

If I may make some comments on style:

Put your file at the end of the OBJS variable (or in some sort of 
sensible order).

Put your file at the end of the tests (or in some sort of sensible 
order).

Refrain from self-evident comments, such as

+ /*
+  * function handles input for the uuid datatype
+ */
+ Datum uuid_in(PG_FUNCTION_ARGS)

You can probably delete all comments in your patch by that criterion.

This sort of super-verbose coding might be alright, but it gets tiring 
when done systematically for no reason:

+ 	result = DirectFunctionCall1(textin, uuid_str);
+ 	return result;	

The uuid.c file claims it is uuid.h.

Move the stuff from builtins.h to uuid.h.

Move the stuff from uuid.h that is not needed anywhere else to uuid.c.

No // comments.

Don't number the tests.  We might want to insert something later and 
that would mess everything up.

Capitalize the SQL test scripts as in other files.

Remove gratuitous whitespace changes (there are many).

Also remove the whitespace at the end of lines.

Make some reasonable effort to align the catalog entries for 
readability.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-01-25 23:05:08
Subject: Re: DROP FUNCTION failure: cache lookup failed for
Previous:From: Bruce MomjianDate: 2007-01-25 22:10:13
Subject: Re: [HACKERS] Win32 WEXITSTATUS too

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group