Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Win32 WEXITSTATUS too

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Win32 WEXITSTATUS too
Date: 2007-01-22 18:52:11
Message-ID: 200701221852.l0MIqBJ04773@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > 
> > I have applied a modified version of this patch.  We now print the
> > exception value in hex, and give a URL where the exception can be looked
> > up.
> 
> Humm, wouldn't it be more appropriate to put the URL in a errhint()
> instead?
> 
> > + 		ereport(lev,
> > + 
> > + 		/*------
> > + 		  translator: %s is a noun phrase describing a child process, such as
> > + 		  "server process" */
> > + 				(errmsg("%s (PID %d) was terminated by exception %X\nSee http://source.winehq.org/source/include/ntstatus.h for a description\nof the hex value.",
> > + 						procname, pid, WTERMSIG(exitstatus))));
> > + #endif

Oops, forgot to mention that detail.  We are using log_error() in one
case, and ereport() in another.  Let me do the hint in the report case,
but I have to leave the log_error case alone because it takes only three
arguments.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Kenneth MarshallDate: 2007-01-22 19:00:34
Subject: Re: [HACKERS] Autovacuum Improvements
Previous:From: Merlin MoncureDate: 2007-01-22 18:49:48
Subject: Re: savepoint improvements

pgsql-patches by date

Next:From: Tom LaneDate: 2007-01-22 19:22:08
Subject: Re: [HACKERS] Win32 WEXITSTATUS too
Previous:From: Alvaro HerreraDate: 2007-01-22 18:46:25
Subject: Re: [HACKERS] Win32 WEXITSTATUS too

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group