Re: [HACKERS] [PATCHES] SGML index build fix

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] SGML index build fix
Date: 2007-01-10 16:36:27
Message-ID: 200701101636.l0AGaRD25568@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut wrote:
> Am Mittwoch, 10. Januar 2007 01:41 schrieb Bruce Momjian:
> > Peter Eisentraut wrote:
> > > Bruce Momjian wrote:
> > > > > ? %-A4.tex-ps: %.sgml $(ALLSGML) stylesheet.dsl bookindex.sgml
> > > > > ? ????$(JADE.tex.call) -V texdvi-output -V '%paper-type%'=A4 -o $@ $<
> > > > > + ifndef DRAFT
> > > > > + ????(at)cmp -s HTML.index.start HTML.index || $(MAKE) $*
> > > > > + endif
> > >
> > > What is the point of that?
> >
> > If HTML.index changed during the build, we need to rerun it until it is
> > unchanged.
>
> But that rule doesn't change HTML.index.

Now that the rule is right:

%-A4.tex-ps: %.sgml $(ALLSGML) stylesheet.dsl bookindex.sgml
$(JADE.tex.call) -V texdvi-output -V '%paper-type%'=A4 -o $@ $<
ifndef DRAFT
@cmp -s HTML.index.start HTML.index || $(MAKE) $@
endif

The rule re-runs the makefile for the specific target, and the target
modifies HTML.index, or it is only the HTML rule that modifies that.
That was a question I had. If that is true, it has to be:

%-A4.tex-ps: %.sgml $(ALLSGML) stylesheet.dsl bookindex.sgml
$(JADE.tex.call) -V texdvi-output -V '%paper-type%'=A4 -o $@ $<
ifndef DRAFT
@cmp -s HTML.index.start HTML.index || $(MAKE) html $@
endif

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-10 16:45:17 Re: [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5
Previous Message Alvaro Herrera 2007-01-10 16:36:26 Re: [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-10 16:38:20 Re: [pgsql-patches] xlog lockup patch (was: BUG #2712:
Previous Message Alvaro Herrera 2007-01-10 16:36:26 Re: [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5