Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] [BUGS] BUG #2846: inconsistent and

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Roman Kononov <kononov195-pgsql(at)yahoo(dot)com>
Subject: Re: [HACKERS] [BUGS] BUG #2846: inconsistent and
Date: 2007-01-02 20:01:50
Message-ID: 200701022001.l02K1ot21807@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Applied.

---------------------------------------------------------------------------

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > OK, are you saying that there is a signal we are ignoring for
> > > overflow/underflow, or that we should just silently overflow/underflow
> > > and not throw an error?
> > 
> > Silent underflow is fine with me; it's the norm in most all float
> > implementations and won't surprise anyone.  For overflow I'm OK with
> > either returning infinity or throwing an error --- but if an error,
> > it should only be about inf-out-with-non-inf-in, not comparisons to any
> > artificial MAX/MIN values.
> 
> OK, I am happy to remove the MIN/MAX comparisons.  Those were in the
> original code.
> 
> The attached, updated patch creates a single CHECKFLOATVAL() macro that
> does the overflow/underflow comparisons and throws an error.  This also
> reduces the isinf() calls.  Should I be concerned we are now duplicating
> the error text in all call sites?
> 
> Regression wording modified now that float4/float8 checks are merged.  I
> haven't update the platform-specific float* expected files yet, but will
> on commit.
> 
> -- 
>   Bruce Momjian   bruce(at)momjian(dot)us
>   EnterpriseDB    http://www.enterprisedb.com
> 
>   + If your life is a hard drive, Christ can be your backup. +


> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2007-01-02 20:04:23
Subject: Re: TODO: GNU TLS
Previous:From: Stephen FrostDate: 2007-01-02 20:01:34
Subject: Re: TODO: GNU TLS

pgsql-patches by date

Next:From: Tom LaneDate: 2007-01-02 20:08:32
Subject: Re: [PATCHES] xlog directory at initdb time
Previous:From: Casey DuncanDate: 2007-01-02 19:43:54
Subject: Re: [PATCHES] xlog directory at initdb time

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group