Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] xlog directory at initdb time

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Subject: Re: [PATCHES] xlog directory at initdb time
Date: 2007-01-02 19:00:27
Message-ID: 200701021900.l02J0RY05709@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira:
> >> This simple patch lets someone specifies the xlog directory at initdb
> >> time. It uses symlinks to do it, and create and/or set permissions at
> >> the directory as appropriate.
> 
> > We already had this functionality in initdb a few versions ago.  Did you 
> > review why it was removed?
> 
> The discussion thread seems to start here:
> 
> http://archives.postgresql.org/pgsql-hackers/2002-08/msg00306.php
> 
> As best I can tell the objections came from the fact that Thomas had
> implemented it as a postmaster-start-time switch, which made it a
> foot-gun because you could mistakenly start the postmaster with a
> different XLOG than you were using before.  That would not apply to a
> symlink-made-by-initdb approach.  All this is doing is formalizing
> something we already suggest people do by hand...

Right.  Thomas decided he didn't want to adjust the patch based on
community input, so the patch was removed.  It was one of the few cases
where I had to back out someone else's patch against their will.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Lukas Kahwe SmithDate: 2007-01-02 19:01:57
Subject: Re: TODO: Add a GUC to control whether BEGIN inside
Previous:From: Tom LaneDate: 2007-01-02 18:55:28
Subject: Re: TODO: GNU TLS

pgsql-patches by date

Next:From: Casey DuncanDate: 2007-01-02 19:43:54
Subject: Re: [PATCHES] xlog directory at initdb time
Previous:From: Heikki LinnakangasDate: 2007-01-02 16:15:13
Subject: Re: Index split WAL reduction

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group