Skip site navigation (1) Skip section navigation (2)

Re: Patch to log usage of temporary files

From: Bill Moran <wmoran(at)collaborativefusion(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to log usage of temporary files
Date: 2007-01-02 22:15:31
Message-ID: 20070102171531.71ce1176.wmoran@collaborativefusion.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
In response to Alvaro Herrera <alvherre(at)commandprompt(dot)com>:

> Bill Moran wrote:
> > 
> > Thanks to Simon Riggs and Bruce for input that helped me put this together.
> 
> Please change things to save the stat() syscall when the feature is not
> in use.

Do you have a suggestion on how to do that and still have the PG_TRACE1()
work?  That was specifically requested by Simon Riggs.

I'm not at all familiar with how the PG_TRACE probes work, so I'd be
interested to hear suggestions on how to wrap that in an if.  If I remove
the PG_TRACE, it becomes a simple matter to skip the stat() if the feature
is disabled.

> Nitpick: also note our brace placement convention (though this would be
> fixed by pgindent, but still).

Sorry, I thought I _was_ following the convention.  Must have missed
something.  Is there a written style guide somewhere?  Might drive things
home a little better than just looking at other folks code.

-- 
Bill Moran
Collaborative Fusion Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-01-02 23:20:37
Subject: Re: Patch to log usage of temporary files
Previous:From: Andrew DunstanDate: 2007-01-02 22:07:38
Subject: Re: Patch to log usage of temporary files

pgsql-patches by date

Next:From: Tom LaneDate: 2007-01-02 23:20:37
Subject: Re: Patch to log usage of temporary files
Previous:From: Andrew DunstanDate: 2007-01-02 22:07:38
Subject: Re: Patch to log usage of temporary files

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group