Re: New version of money type

From: "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: New version of money type
Date: 2006-12-31 20:49:38
Message-ID: 20061231154938.fa5f7b36.darcy@druid.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 21 Dec 2006 10:47:52 -0500
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> One bug I see in it is that you'd better make the alignment 'd' if the
> type is to be int8. Also I much dislike these changes:
>
> - int32 i = PG_GETARG_INT32(1);
> + int64 i = PG_GETARG_INT32(1);

I changed this and a few other things. I didn't see any response to my
question though. Shall I go ahead and commit now so that we can test
in a wider setting? I haven't committed anything in years and I am
hesitant to do so now without consencus.

--
D'Arcy J.M. Cain <darcy(at)druid(dot)net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-12-31 22:51:30 Re: access method's algorithm authors
Previous Message Jaime Casanova 2006-12-31 20:05:30 access method's algorithm authors