Skip site navigation (1) Skip section navigation (2)

pgsql: Repair bug #2839: the various ExecReScan functions need to reset

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Repair bug #2839: the various ExecReScan functions need to reset
Date: 2006-12-26 19:27:04
Message-ID: 20061226192704.2BD929FA2D4@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Repair bug #2839: the various ExecReScan functions need to reset
ps_TupFromTlist in plan nodes that make use of it.  This was being done
correctly in join nodes and Result nodes but not in any relation-scan nodes.
Bug would lead to bogus results if a set-returning function appeared in the
targetlist of a subquery that could be rescanned after partial execution,
for example a subquery within EXISTS().  Bug has been around forever :-(
... surprising it wasn't reported before.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/backend/executor:
        nodeBitmapHeapscan.c (r1.4.2.1 -> r1.4.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeBitmapHeapscan.c.diff?r1=1.4.2.1&r2=1.4.2.2)
        nodeFunctionscan.c (r1.35 -> r1.35.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeFunctionscan.c.diff?r1=1.35&r2=1.35.2.1)
        nodeIndexscan.c (r1.104.2.1 -> r1.104.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeIndexscan.c.diff?r1=1.104.2.1&r2=1.104.2.2)
        nodeResult.c (r1.32 -> r1.32.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeResult.c.diff?r1=1.32&r2=1.32.2.1)
        nodeSeqscan.c (r1.54 -> r1.54.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSeqscan.c.diff?r1=1.54&r2=1.54.2.1)
        nodeSubqueryscan.c (r1.27 -> r1.27.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSubqueryscan.c.diff?r1=1.27&r2=1.27.2.1)
        nodeTidscan.c (r1.43 -> r1.43.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeTidscan.c.diff?r1=1.43&r2=1.43.2.1)

pgsql-committers by date

Next:From: Tom LaneDate: 2006-12-26 19:27:10
Subject: pgsql: Repair bug #2839: the various ExecReScan functions need to reset
Previous:From: Tom LaneDate: 2006-12-26 19:26:56
Subject: pgsql: Repair bug #2839: the various ExecReScan functions need to reset

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group