Skip site navigation (1) Skip section navigation (2)

pgsql: Bring some order and sanity to error handling in the xml patch.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Bring some order and sanity to error handling in the xml patch.
Date: 2006-12-24 18:25:59
Message-ID: 20061224182559.5F76B9FA294@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Bring some order and sanity to error handling in the xml patch.
Use a TRY block instead of (inadequate) ad-hoc coding to ensure that
libxml is cleaned up after a failure.  Report the intended SQLCODE
instead of defaulting to XX000.  Avoid risking use of a dangling
pointer by keeping the persistent error buffer in TopMemoryContext.
Be less trusting that error messages don't contain %.

This patch doesn't do anything about changing the way the messages
are put together --- this is just about mechanism.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        xml.c (r1.4 -> r1.5)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/xml.c.diff?r1=1.4&r2=1.5)

pgsql-committers by date

Next:From: Tom LaneDate: 2006-12-24 19:14:28
Subject: pgsql: Make HISTCONTROL=ignoredups work again (broken by misordering of
Previous:From: Tom LaneDate: 2006-12-24 18:15:32
Subject: Re: Loose ends in PG XML patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group