Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Fix some translator comments so that

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Fix some translator comments so that
Date: 2006-11-28 21:51:25
Message-ID: 200611282151.kASLpPU21015@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > I looked at the first URL diff.  How is the pgindent output poor?
> 
> xgettext extracts comments if the first token of the comment is the tag 
> we choose ("translator").  But if the comment is formatted like
> 
> /*
>  * translator: first %s is name of a SQL
>  * construct, eg ORDER BY
>  */
> 
> then the first token of the comment is actually the second "*", so 
> xgettext doesn't take it.
> 
> So we'd need a way for those comments to not be formatted that way.

OK, next question.  Why does xgettext pull comments?  For the assistance
of the translator?

Looking at the diff, your new version uses "/*------" to mark the
comments --- that will prevent pgindent from modifying the comment, so
perhaps that is the right solution.  One thing we could do is look for
"/* translator" comments and manually change them.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-11-28 22:03:52
Subject: Re: Double entries in log for page slots in beta3
Previous:From: Kevin GrittnerDate: 2006-11-28 21:48:08
Subject: Re: Double entries in log for page slots in beta3

pgsql-committers by date

Next:From: Tom LaneDate: 2006-11-28 22:54:18
Subject: pgsql: Add an example showing how to cope with mixed-case names in
Previous:From: Peter EisentrautDate: 2006-11-28 21:46:21
Subject: Re: [COMMITTERS] pgsql: Fix some translator comments so that xgettext finds them and

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group