Re: [HACKERS] [PERFORM] Direct I/O issues

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Greg Smith <gsmith(at)gregsmith(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PERFORM] Direct I/O issues
Date: 2006-11-24 23:43:36
Message-ID: 200611242343.kAONha502736@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches pgsql-performance

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Not sure if people want this for 8.2. I think we can modify
> > test_fsync.c anytime but the movement of the defines into an include
> > file is a backend code change.
>
> I think fooling with this on the day before RC1 is an unreasonable risk ...
> and I disapprove of moving this code into a widely-used include file
> like xlog.h, too.

OK, you want a separate include or xlog_internal.h? And should I put in
just the test_fsync changes next week so at least we are closer to
having it work for 8.2?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-11-24 23:44:21 Re: libpq-fe: PQgetvalue() ?
Previous Message Bruce Momjian 2006-11-24 23:41:41 Re: Error in from_char() for field 'D'?

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2006-11-25 00:28:28 Re: Avg performance for int8/numeric
Previous Message Bruce Momjian 2006-11-24 23:41:41 Re: Error in from_char() for field 'D'?

Browse pgsql-performance by date

  From Date Subject
Next Message Tom Lane 2006-11-25 00:10:05 Re: Postgres scalability and performance on windows
Previous Message Tom Lane 2006-11-24 19:08:34 Re: [PERFORM] Direct I/O issues