Skip site navigation (1) Skip section navigation (2)

pgsql: Repair problems with hash indexes that span multiple segments:

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Repair problems with hash indexes that span multiple segments:
Date: 2006-11-19 21:33:29
Message-ID: 20061119213329.2D0DB9FA170@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Repair problems with hash indexes that span multiple segments: the hash code's
preference for filling pages out-of-order tends to confuse the sanity checks
in md.c, as per report from Balazs Nagy in bug #2737.  The fix is to ensure
that the smgr-level code always has the same idea of the logical EOF as the
hash index code does, by using ReadBuffer(P_NEW) where we are adding a single
page to the end of the index, and using smgrextend() to reserve a large batch
of pages when creating a new splitpoint.  The patch is a bit ugly because it
avoids making any changes in md.c, which seems the most prudent approach for a
backpatchable beta-period fix.  After 8.3 development opens, I'll take a look
at a cleaner but more invasive patch, in particular getting rid of the now
unnecessary hack to allow reading beyond EOF in mdread().

Backpatch as far as 7.4.  The bug likely exists in 7.3 as well, but because
of the magnitude of the 7.3-to-7.4 changes in hash, the later-version patch
doesn't even begin to apply.  Given the other known bugs in the 7.3-era hash
code, it does not seem worth trying to develop a separate patch for 7.3.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/backend/access/hash:
        hashovfl.c (r1.47.2.1 -> r1.47.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/hash/hashovfl.c.diff?r1=1.47.2.1&r2=1.47.2.2)
        hashpage.c (r1.52.2.1 -> r1.52.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/hash/hashpage.c.diff?r1=1.52.2.1&r2=1.52.2.2)

pgsql-committers by date

Next:From: Tom LaneDate: 2006-11-19 21:33:37
Subject: pgsql: Repair problems with hash indexes that span multiple segments:
Previous:From: Tom LaneDate: 2006-11-19 21:33:23
Subject: pgsql: Repair problems with hash indexes that span multiple segments:

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group