From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: workaround for buggy strtod is not necessary |
Date: | 2006-10-03 21:48:36 |
Message-ID: | 200610032148.k93LmaN17593@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Zdenek Kotala wrote:
>
> Solaris had broken strtod function when parse "Inf" and "Nan". See
> solaris.h. This bug has been fixed for all current versions of Solaris (
> 8, 9, 10). See
>
> http://sunsolve.sun.com/search/document.do?assetkey=1-21-108993-62-1&searchclause=108993-62
> http://sunsolve.sun.com/search/document.do?assetkey=1-21-112874-34-1&searchclause=112874-34
>
>
> Workaround is not necessary now, but I'm not sure if workaround removing
> is good idea. There are some possible variants:
>
>
> 1) keep workaround in the code for compatibility with unpatched system
> and adjust comment in solaris.h
>
> 2) remove workaround and mention required Solaris patch in the
> Solaris.FAQ document
>
> 3) add some test into configure script and use workaround only on
> unpatched system. (It should be nightmare for packagers)
#1. What do you want to change about the existing comment?
/*
* Many versions of Solaris have broken strtod() --- see bug #4751182.
* For the moment we just assume they all do; it's probably not worth
* the trouble to add a configure test for this.
*/
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-10-03 21:55:52 | Re: PG qsort vs. Solaris |
Previous Message | Bruce Momjian | 2006-10-03 21:46:56 | Re: [HACKERS] scripts/common.c minor memory leak |