Andrew Dunstan wrote:
> Martijn van Oosterhout wrote:
> > Just a minor thing. In yesno_prompt(), the value is resp is allocated
> > memory that is never freed.
> > File: src/bin/scripts/common.c
> > Line: 218
> > Not terribly important though, it's not used in critical utilities, but
> > it's used often.
> > Found by coverity.
> It is surely not the only memory leak. We know there are some and in
> most cases (like this) they aren't worth the trouble to clean up. If it
> were used in psql or the backend I'd be worried, but it isn't, so I'm not.
I have applied the attached patch to fix this. One reason I think it is
good to fix this is because it illustrates poor use of simple_prompt(),
that might be copied by others.
Bruce Momjian bruce(at)momjian(dot)us
+ If your life is a hard drive, Christ can be your backup. +
Description: text/x-diff (1.5 KB)
In response to
pgsql-hackers by date
|Next:||From: Bruce Momjian||Date: 2006-10-03 21:48:36|
|Subject: Re: workaround for buggy strtod is not necessary|
|Previous:||From: Zdenek Kotala||Date: 2006-10-03 21:37:33|
|Subject: workaround for buggy strtod is not necessary|
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2006-10-03 22:12:17|
|Subject: Re: pgevent fixes|
|Previous:||From: Andrew Dunstan||Date: 2006-10-03 21:27:31|
|Subject: Re: scripts/common.c minor memory leak|