From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Michael Glaesemann <grzm(at)seespotcode(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Interval month, week -> day |
Date: | 2006-09-04 02:21:11 |
Message-ID: | 200609040221.k842LB001848@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Michael Glaesemann <grzm(at)seespotcode(dot)net> writes:
> > On Sep 4, 2006, at 9:41 , Tom Lane wrote:
> >> This patch fails to apply --- looks like whitespace got mangled in
> >> transit. Please resend as an attachment.
>
> > Please let me know if you have any problems with this one.
>
> Ah, that one works --- applied. A few comments:
>
> * You worried about the "tmask" coding in your original message, but
> I think that's OK as-is. The point of that code, IIUC, is to reject
> multiple specifications of the same field type, eg '1 day 2 days'.
> If we changed it then we'd reject '1.5 month 2 days', whereas I think
> least surprise would dictate adding the components to give 1 month
> 17 days.
>
> * AFAICT the ecpg regression tests are not affected by this change.
>
> * You mentioned being unable to get the ecpg tests to run on your
> machine. I'm sure Michael and Joachim would like the details. The
> ecpg regression tests are pretty new and some portability problems
> are to be expected, but they seem to be passing on all the machines
> Michael and Joachim and I have access to.
When I tried the ecpg regression tests it complained there was no
results/ directory. I created one and it worked.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-09-04 02:21:41 | Re: autoconf version for back branches? |
Previous Message | Bruce Momjian | 2006-09-04 02:19:09 | Re: Getting a move on for 8.2 beta |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-09-04 03:49:13 | Re: pgstattuple extension for indexes |
Previous Message | Tom Lane | 2006-09-04 02:13:41 | Re: pgstattuple extension for indexes |