| From: | Joachim Wieland <joe(at)mcknight(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org, meskes(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Subject: | Re: [PATCHES] Another VPATH patch for ecpg |
| Date: | 2006-08-28 21:03:25 |
| Message-ID: | 20060828210325.GC2826@mcknight.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Mon, Aug 28, 2006 at 12:16:40PM -0400, Tom Lane wrote:
> 122c122
> < #line 36 "show.pgc"
> AFAICS there is no very good way to deal with this. I'd suggest
> providing a way to suppress #line output from the ecpg preprocessor,
> but perhaps there is another answer.
What about changing those lines before diffing the files? This is already
done for different default port settings in order to keep output files in
sync.
I append a small (untested) patch against pg_regress.sh.
Unfortunately, lines like this one in a non-VPATH build:
#line 1 "./../../include/sql3types.h"
would get stripped to `#line 1 "sql3types.h"' as well but I think this is
acceptable.
Joachim
--
Joachim Wieland joe(at)mcknight(dot)de
GPG key available
| Attachment | Content-Type | Size |
|---|---|---|
| pg_regress.vpath.diff | text/plain | 674 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-28 21:57:48 | Re: tsvector/tsearch equality and/or portability issue |
| Previous Message | Tom Lane | 2006-08-28 20:05:35 | Re: autovacuum causing numerous regression-test failures |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Mair | 2006-08-28 21:59:34 | Re: [PATCHES] updated patch for selecting large results |
| Previous Message | Chris Mair | 2006-08-28 19:17:30 | Re: [PATCHES] updated patch for selecting large results sets in |