Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Trivial patch to double vacuum speed on tables with no indexes

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Trivial patch to double vacuum speed on tables with no indexes
Date: 2006-08-28 14:18:35
Message-ID: 20060828141835.GC27526@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Gregory Stark wrote:
> 
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> 
> > The reason the patch is so short is that it's a kluge.  If we really
> > cared about supporting this case, more wide-ranging changes would be
> > needed (eg, there's no need to eat maintenance_work_mem worth of RAM
> > for the dead-TIDs array); and a decent respect to the opinions of
> > mankind would require some attention to updating the header comments
> > and function descriptions, too.
> 
> The only part that seems klugy to me is how it releases the lock and
> reacquires it rather than wait in the first place until it can acquire the
> lock. Fixed that and changed lazy_space_alloc to allocate only as much space
> as is really necessary.
> 
> Gosh, I've never been accused of offending all mankind before.

Does that feel good or bad?

I won't comment on the spirit of the patch but I'll observe that you
should respect mankind a little more by observing brace position in
if/else ;-)



-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

pgsql-hackers by date

Next:From: chrisnospamDate: 2006-08-28 14:29:38
Subject: updated patch for selecting large results sets in psql using cursors
Previous:From: Tatsuo IshiiDate: 2006-08-28 14:16:57
Subject: Rtree circle ops

pgsql-patches by date

Next:From: chrisnospamDate: 2006-08-28 14:29:38
Subject: updated patch for selecting large results sets in psql using cursors
Previous:From: ITAGAKI TakahiroDate: 2006-08-28 10:17:41
Subject: Re: [HACKERS] CSStorm occurred again by postgreSQL8.2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group