Skip site navigation (1) Skip section navigation (2)

Re: Updatable views

From: "mailings(at)oopsware(dot)de "<mailings(at)oopsware(dot)de>
To: alvherre(at)commandprompt(dot)com
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Updatable views
Date: 2006-08-26 19:10:55
Message-ID: 20060826191055.46FF849B6C@dd1514.kasserver.com (view raw or flat)
Thread:
Lists: pgsql-patches

----- Original Message -----
From: alvherre(at)commandprompt(dot)com <Alvaro Herrera>
To: mailings(at)oopsware(dot)de
Date: 25.08.2006 00:50:59
Subject: Re: [PATCHES] Updatable views

> 
> Minor suggestion: change get_view_qualification_function to look the
> function by Oid rather than name.  I wasn't sure it was actually a good
> idea to use a function that way, but if it's going to stay ...
> 
> Another: remove create_nothing_rule, replace with call to
> create_rule_stmt.
> 
> Another: change hasRule to return a bool instead of an Oid.
> 
> Another: instead of a comment like this:
> 
>     /*
>      * XXX It seems to me that these checks are not necessary; and further,
>      * they are useless.  This is because the view is just being created,
>      * thus it cannot have any rules before the ones we are going to
>      * create.
>      * 
>      * XXX What about CREATE OR REPLACE VIEW ???
>      */
> 
> have a single paragraph explaining why the replace flag is needed.
> 

Okay, i'll sent a reworked version asap, but can't get to it before monday.
I'm away from my machine this weekend and have only sporadic access
to my email.

    Bernd




pgsql-patches by date

Next:From: Zoltan BoszormenyiDate: 2006-08-26 19:36:14
Subject: Re: [HACKERS] Performance testing of COPY (SELECT) TO
Previous:From: Joshua D. DrakeDate: 2006-08-26 17:21:49
Subject: Re: Adding fulldisjunctions to the contrib

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group