Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] [PATCHES] log_statement output for protocol

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Oliver Jowett <oliver(at)opencloud(dot)com>, Dave Cramer <pg(at)fastcrypt(dot)com>, Csaba Nagy <nagy(at)ecircle-ag(dot)com>, Postgres JDBC <pgsql-jdbc(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] log_statement output for protocol
Date: 2006-08-05 17:39:06
Message-ID: 200608051739.k75Hd6D03844@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-jdbcpgsql-patches
Tom Lane wrote:
> Oliver Jowett <oliver(at)opencloud(dot)com> writes:
> > A 50-parameter query could be .. interesting ..
> 
> > I realize that you need this level of output to reflect what is 
> > happening at the protocol level, but seeing all the protocol detail is 
> > not really what you expect when you turn on basic statement logging, is it?
> 
> Well, we've certainly been beat up often enough about the lack of
> logging bind parameter values --- I don't think there's any question
> about the importance of printing them.  I agree that the proposed format
> is much too verbose though.  In particular, a separate LOG message per
> parameter is NOT what I had in mind; I want them in DETAIL lines of the
> bind log message.  (This'd perhaps also address Oliver's issue, since
> if you didn't want to see the values you could turn down
> log_error_verbosity.)

OK, I will continue in that direction.  Will post a new patch.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-08-05 17:43:32
Subject: Re: Updated INSERT/UPDATE RETURNING
Previous:From: Tom LaneDate: 2006-08-05 17:14:25
Subject: Re: ecpg test suite

pgsql-patches by date

Next:From: Tom LaneDate: 2006-08-05 17:43:32
Subject: Re: Updated INSERT/UPDATE RETURNING
Previous:From: Tom LaneDate: 2006-08-05 16:27:25
Subject: Re: [HACKERS] [PATCHES] log_statement output for protocol

pgsql-jdbc by date

Next:From: Kris JurkaDate: 2006-08-06 18:05:13
Subject: Re: PreparedStatement clearParameters and setTimestamp
Previous:From: Tom LaneDate: 2006-08-05 16:27:25
Subject: Re: [HACKERS] [PATCHES] log_statement output for protocol

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group