Re: Values list-of-targetlists patch for comments (was Re:

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgreSQL(dot)org
Subject: Re: Values list-of-targetlists patch for comments (was Re:
Date: 2006-08-02 18:59:52
Message-ID: 20060802185952.GD6019@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers pgsql-patches

Joe Conway wrote:

> What if we built an array of A_Const nodes instead of a List? Maybe we
> could use something akin to appendStringInfo()/enlargeStringInfo() to
> build the array of nodes and enlarge it in chunks.

In inval.c you find this:

/*
* To minimize palloc traffic, we keep pending requests in successively-
* larger chunks (a slightly more sophisticated version of an expansible
* array). All request types can be stored as SharedInvalidationMessage
* records. The ordering of requests within a list is never significant.
*/
typedef struct InvalidationChunk
{
struct InvalidationChunk *next; /* list link */
int nitems; /* # items currently stored in chunk */
int maxitems; /* size of allocated array in this chunk */
SharedInvalidationMessage msgs[1]; /* VARIABLE LENGTH ARRAY */
} InvalidationChunk; /* VARIABLE LENGTH STRUCTURE */

Which might give you an idea ...

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2006-08-02 19:18:26 Re: Values list-of-targetlists patch for comments (was Re:
Previous Message Joe Conway 2006-08-02 18:10:11 Re: Values list-of-targetlists patch for comments (was Re:

Browse pgsql-hackers by date

  From Date Subject
Next Message Ralf S. Engelschall 2006-08-02 19:04:11 Patch to allow C extension modules to initialize/finish
Previous Message Rocco Altier 2006-08-02 18:45:03 Buildfarm failure - asp

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-08-02 19:18:26 Re: Values list-of-targetlists patch for comments (was Re:
Previous Message Joe Conway 2006-08-02 18:10:11 Re: Values list-of-targetlists patch for comments (was Re: