Skip site navigation (1) Skip section navigation (2)

Re: contrib/pgbench bugfix

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org, itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/pgbench bugfix
Date: 2006-07-31 05:11:39
Message-ID: 20060731.141139.85413307.t-ishii@sraoss.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Good catch!

Thanks. I have committed your fix.
--
Tatsuo Ishii
SRA OSS, Inc. Japan

> I found a buffer overflow bug in contrib/pgbench.
> This occures when -c >= 2.
> 
> 
> 
> The type of 'state' is CState*, so we should use state+1 or &state[1],
> not state + sizeof(*state)
> 
> 
> *** pgbench.c	Mon Jul 31 13:18:45 2006
> --- pgbench.fixed.c	Mon Jul 31 13:18:10 2006
> *************** main(int argc, char **argv)
> *** 1344,1350 ****
>   			exit(1);
>   		}
>   
> ! 		memset(state + sizeof(*state), 0, sizeof(*state) * (nclients - 1));
>   
>   		for (i = 1; i < nclients; i++)
>   		{
> --- 1344,1350 ----
>   			exit(1);
>   		}
>   
> ! 		memset(state + 1, 0, sizeof(*state) * (nclients - 1));
>   
>   		for (i = 1; i < nclients; i++)
>   		{
> 
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq
> 

In response to

pgsql-hackers by date

Next:From: Katsuhiko OkanoDate: 2006-07-31 08:52:31
Subject: Re: LWLock statistics collector (was: CSStorm occurred again by postgreSQL8.2)
Previous:From: Robert LorDate: 2006-07-31 04:50:14
Subject: Re: DTrace enabled build fails

pgsql-patches by date

Next:From: Katsuhiko OkanoDate: 2006-07-31 08:52:31
Subject: Re: LWLock statistics collector (was: CSStorm occurred again by postgreSQL8.2)
Previous:From: ITAGAKI TakahiroDate: 2006-07-31 04:25:54
Subject: contrib/pgbench bugfix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group