Re: [HACKERS] pg_regress breaks on msys

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I modified pg_regress.c to use just the return code to determine if the
> > diff worked, but I added in a WIN32-specific test for the file size. I
> > think that is the cleanest solution. Attached.
>
> It really needs a comment, along the lines of
>
> /*
> * On Windows we'll get exit status 1 if the diff invocation
> * failed; so we need a way to distinguish failure from "files
> * are different". Check to make sure that a diff file was
> * created and is nonempty.
> */
>
> Also the test ought to account for file_size returning -1 if file's
> not there, so
>
> + #ifdef WIN32
> + if (WEXITSTATUS(r) == 1 && file_size(filename) <= 0)
> ...

I had already added a comment this morning, but didn't post the updated
patch. I have made the adjustment for -1.

Patch attached and applied.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +