Skip site navigation (1) Skip section navigation (2)

Re: LDAP lookup of connection parameters

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Albe Laurenz <all(at)adv(dot)magwien(dot)gv(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: LDAP lookup of connection parameters
Date: 2006-07-26 16:46:02
Message-ID: 200607261646.k6QGk2L09408@momjian.us (view raw or flat)
Thread:
Lists: pgsql-patches
Albe Laurenz wrote:
> Bruce Momjian wrote:
> > Albe Laurenz wrote:
> >> This patch for libpq allows you to enter an LDAP URL in
> pg_service.conf.
> >> The URL will be queried and the resulting string(s) parsed for
> >> keyword = value connection options.
> > 
> > I have heavily modified your patch to be clearer.  Please review the
> > attached version and test it to make sure it still works properly. 
> > Thanks.
> 
> Most of your modifications are fine, but a quick look tells me that your
> modifications in the parsing of the LDAP URL have been too invasive,
> e.g.:
> 
> - you look for the port number in the 'dn' and not in the 'hostname'
> - you check the validity of 'scopestr' and 'attrs[0]' before it is
> '\0'-terminated
> 
> Would you prefer that I try to fix your fixes (and stick with your
> coding style)
> or do you want another go?

Thanks for the review.  Updated patch attached.  Is that OK?

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /pgpatches/ldap
Description: text/x-diff (16.1 KB)

In response to

pgsql-patches by date

Next:From: Greg StarkDate: 2006-07-26 16:47:57
Subject: Re: [HACKERS] Resurrecting per-page cleaner for btree
Previous:From: Tom LaneDate: 2006-07-26 16:09:04
Subject: Re: [HACKERS] Resurrecting per-page cleaner for btree

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group