Re: [HACKERS] Overhead for stats_command_string et al, take 2

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Overhead for stats_command_string et al, take 2
Date: 2006-06-26 17:24:39
Message-ID: 200606261724.k5QHOdb20670@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Seeing stats_command_string with almost zero overhead is great news!
> > Should we remove that setting and just have it enabled all
> > the time?
>
> If you don't need it, you shouldn't have to pay any overhead for it,
> I think. One could make an argument now for having stats_command_string
> default to ON, though.

The attached patch makes stats_command_string default to 'on', and
updates the documentation.

> Something that might also be interesting is an option to suppress
> per-command ps_status reporting. On machines where updating ps status
> takes a kernel call, there's now a pretty good argument why you might
> want to turn that off and rely on pg_stat_activity instead.

OK, can I get a timing report from someone with the title on/off that
shows a difference?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/pgpatches/stat.on text/x-diff 6.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-06-26 17:24:41 pgsql: Change the row constructor syntax (ROW(...)) so that list
Previous Message Stefan Kaltenbrunner 2006-06-26 17:08:54 GIN index creation extremely slow ?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-06-26 17:32:04 Re: [HACKERS] Overhead for stats_command_string et al, take 2
Previous Message Bruce Momjian 2006-06-26 16:40:53 Re: Overhead for stats_command_string et al, take 2