Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Overhead for stats_command_string et al, take 2

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Overhead for stats_command_string et al, take 2
Date: 2006-06-26 17:24:39
Message-ID: 200606261724.k5QHOdb20670@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Seeing stats_command_string with almost zero overhead is great news!
> > Should we remove that setting and just have it enabled all
> > the time?
> 
> If you don't need it, you shouldn't have to pay any overhead for it,
> I think.  One could make an argument now for having stats_command_string
> default to ON, though.

The attached patch makes stats_command_string default to 'on', and
updates the documentation.

> Something that might also be interesting is an option to suppress
> per-command ps_status reporting.  On machines where updating ps status
> takes a kernel call, there's now a pretty good argument why you might
> want to turn that off and rely on pg_stat_activity instead.

OK, can I get a timing report from someone with the title on/off that
shows a difference?

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /pgpatches/stat.on
Description: text/x-diff (6.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-06-26 17:24:41
Subject: pgsql: Change the row constructor syntax (ROW(...)) so that list
Previous:From: Stefan KaltenbrunnerDate: 2006-06-26 17:08:54
Subject: GIN index creation extremely slow ?

pgsql-patches by date

Next:From: Tom LaneDate: 2006-06-26 17:32:04
Subject: Re: [HACKERS] Overhead for stats_command_string et al, take 2
Previous:From: Bruce MomjianDate: 2006-06-26 16:40:53
Subject: Re: Overhead for stats_command_string et al, take 2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group