Skip site navigation (1) Skip section navigation (2)

SVN Commit by dpage: r5234 - trunk/pgadmin3/src/utils

From: svn(at)pgadmin(dot)org
To: pgadmin-hackers(at)postgresql(dot)org
Subject: SVN Commit by dpage: r5234 - trunk/pgadmin3/src/utils
Date: 2006-06-19 12:15:35
Message-ID: 200606191215.k5JCFZNg032110@developer.pgadmin.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Author: dpage

Date: 2006-06-19 13:15:35 +0100 (Mon, 19 Jun 2006)

New Revision: 5234

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5234&view=rev

Log:
Andreas reports:
> When triggering autocomplete on spaces (e.g. empty query 
> window), a memory damage will be triggered. If ignored, the 
> full keyword listbox will popup.
> Happens with VC6, not gtk.

Apologies for the delay in dealing with this, been way too busy.
Attached is a fix. A buffer in _complete_from_list() wasn't allocaed
with enough space for the terminating NULL. I've fixed a similar issue
in complete_create_command - I wasn't able to trigger it, but anyway.

It really should hapen on gtk as well - most likely just luck that it
didn't corrupt anything needed. [Magnus Hagander]



Modified:
   trunk/pgadmin3/src/utils/tabcomplete.c

pgadmin-hackers by date

Next:From: Dave PageDate: 2006-06-19 12:16:20
Subject: Re: Problem with autocomplete
Previous:From: svnDate: 2006-06-19 12:11:48
Subject: SVN Commit by dpage: r5233 - trunk/pgadmin3/src/ctl

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group