Skip site navigation (1) Skip section navigation (2)

Re: Patch for snprintf problem (bug #1000650) 4-th try

From: Ludek Finstrle <luf(at)pzkagis(dot)cz>
To: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: pgsql-odbc(at)postgresql(dot)org
Subject: Re: Patch for snprintf problem (bug #1000650) 4-th try
Date: 2006-06-13 09:46:17
Message-ID: 20060613094617.GA28219@soptik.pzkagis.cz (view raw or flat)
Thread:
Lists: pgsql-odbc
> > > > buf = "text";
> > > > snprintf(buf,size,"%s append",buf);
> > > > 
> > > > buf = "text append" on Windows (MS VC compiler)
> > > > buf = " append" on linux (gcc compiler)
> > > > 
> > > > I solve it this way (main idea):
> > > > snprintf(buf + strlen(buf), " append");
> > > 
> > > Hmm bad news.
> > > If so, it may be better to use the sequence like the following for example.
> > > 
> > > 	char	*query_ptr;
> > > 	size_t	bufsize_res;
> > > 	int	slen;
> > > 
> > > 	/* Initialize */
> > > 	query_ptr = columns_query;
> > > 	bufsize_res = sizeof(columns_query);
> > > 
> > > 	if (..)
> > > 	{
> > > 		if ((slen = snprintf(query_ptr, bufsize_res, .., )) <= 0)
> > > 		{
> > > 			.. error_handling ..
> > > 		}
> > > 		query_ptr += slen;
> > > 		bufsize_res -= slen;
> > > 	}
> > > 
> > > 	...
> > 
> > I'm not sure. There are a lot of strcat, my_strcat, schema_strcat calls
> > between snprintf. There is only one place where snprintf could be called
> > after another snprintf.
> 
> I change the snprintf_addlen to snprintf_len as you mentioned.
> 
> Third try of patch attached.

I make patch againist CVS after yours huge commit. What's your opinion?
Could we fix linux bug? Or do you prefer ifdef or what's your
idea about change these lines:

snprintf(buf,bufsize,"%s adding 1",buf);
strcat(buf," adding 2");
snprintf(buf,bufsize,"%s adding 3",buf);

I think it's hard to maintain code you mentioned above. This calls
are only in catalog information (relatively short query - used not so
often).

Patch attached contains previous psqlodbc_snprintf_3try and
psqlodbc_snprintf_next.

Regards,

Luf

In response to

Responses

pgsql-odbc by date

Next:From: Campbell, GregDate: 2006-06-13 14:06:04
Subject: Re: [compgeneral] I cant get the description or default valueof a field
Previous:From: serkaneDate: 2006-06-13 08:33:20
Subject: Re: I cant get the description or default value of a field

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group