Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling
Date: 2006-06-01 06:47:06
Message-ID: 20060601064706.GB12689@svana.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Tue, May 30, 2006 at 10:01:49AM -0400, Bruce Momjian wrote:
> 
> Patch applied.  Thanks.

I note Tom made some changes to this patch after it went in. For the
record, it was always my intention that samplecount count the number of
_tuples_ returned while sampling, rather than the number of
_iterations_. I'll admit the comment in the header was wrong.

While my original patch had a small error in the case of multiple
tuples returned, it would've been correctable by counting the actual
number of sample. The way it is now, it will show a bias if the number
of tuples returned increases after the first sampled 50 tuples.
However, my knowledge of statistics isn't good enough to determine if
this is an actual problem or not, since the way it is now will sample
more initialially...

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

pgsql-hackers by date

Next:From: David HokszaDate: 2006-06-01 08:10:38
Subject: Re: session id and global storage
Previous:From: Martijn van OosterhoutDate: 2006-06-01 05:42:23
Subject: Re: Possible TODO item: copy to/from pipe

pgsql-patches by date

Next:From: Joachim WielandDate: 2006-06-01 08:25:17
Subject: TODO-Item: full timezone names
Previous:From: Bruce MomjianDate: 2006-06-01 05:12:43
Subject: Re: [HACKERS] psql \copy warning

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group