pgsql: Fix up pg_dump to do string escaping fully correctly for client

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix up pg_dump to do string escaping fully correctly for client
Date: 2006-05-28 21:13:54
Message-ID: 20060528211354.A1E609FA38E@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix up pg_dump to do string escaping fully correctly for client encoding
and standard_conforming_strings; likewise for the other client programs
that need it. As per previous discussion, a pg_dump dump now conforms
to the standard_conforming_strings setting of the source database.
We don't use E'' syntax in the dump, thereby improving portability of
the SQL. I added a SET escape_strings_warning = off command to keep
the dumps from getting a lot of back-chatter from that.

Modified Files:
--------------
pgsql/src/backend/utils/adt:
quote.c (r1.19 -> r1.20)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/quote.c.diff?r1=1.19&r2=1.20)
ruleutils.c (r1.222 -> r1.223)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c.diff?r1=1.222&r2=1.223)
pgsql/src/bin/pg_dump:
dumputils.c (r1.28 -> r1.29)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/dumputils.c.diff?r1=1.28&r2=1.29)
dumputils.h (r1.16 -> r1.17)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/dumputils.h.diff?r1=1.16&r2=1.17)
pg_backup.h (r1.38 -> r1.39)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup.h.diff?r1=1.38&r2=1.39)
pg_backup_archiver.c (r1.130 -> r1.131)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_archiver.c.diff?r1=1.130&r2=1.131)
pg_backup_archiver.h (r1.69 -> r1.70)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_archiver.h.diff?r1=1.69&r2=1.70)
pg_dump.c (r1.435 -> r1.436)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.435&r2=1.436)
pg_dumpall.c (r1.76 -> r1.77)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c.diff?r1=1.76&r2=1.77)
pgsql/src/bin/psql:
describe.c (r1.136 -> r1.137)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c.diff?r1=1.136&r2=1.137)
large_obj.c (r1.42 -> r1.43)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/large_obj.c.diff?r1=1.42&r2=1.43)
pgsql/src/bin/scripts:
createdb.c (r1.17 -> r1.18)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/createdb.c.diff?r1=1.17&r2=1.18)
createuser.c (r1.28 -> r1.29)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/createuser.c.diff?r1=1.28&r2=1.29)
pgsql/src/include:
c.h (r1.201 -> r1.202)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h.diff?r1=1.201&r2=1.202)
pgsql/src/interfaces/libpq:
fe-exec.c (r1.185 -> r1.186)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-exec.c.diff?r1=1.185&r2=1.186)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-05-28 22:42:05 pgsql: enlargePQExpBuffer, alone among the functions exported by
Previous Message Alvaro Herrera 2006-05-28 17:23:29 pgsql: Don't call PQclear until the struct is really no longer going to