Skip site navigation (1) Skip section navigation (2)

pgsql: Don't call PQclear until the struct is really no longer going to

From: alvherre(at)postgresql(dot)org (Alvaro Herrera)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't call PQclear until the struct is really no longer going to
Date: 2006-05-28 17:23:29
Message-ID: 20060528172329.BA7A69FA38E@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Don't call PQclear until the struct is really no longer going to be used.
Per Coverity bug #304.  Thanks to Martijn van Oosterhout for reporting it.

Zero out the pointer fields of PGresult so that these mistakes are more
easily catched, per discussion.

Modified Files:
--------------
    pgsql/src/interfaces/libpq:
        fe-exec.c (r1.184 -> r1.185)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-exec.c.diff?r1=1.184&r2=1.185)
    pgsql/src/bin/pg_dump:
        pg_dump.c (r1.434 -> r1.435)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.434&r2=1.435)

pgsql-committers by date

Next:From: Tom LaneDate: 2006-05-28 21:13:54
Subject: pgsql: Fix up pg_dump to do string escaping fully correctly for client
Previous:From: User NwakefieldDate: 2006-05-28 16:14:48
Subject: bizgres - bizgres: Enhancement: Added code to automatically create the

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group