Tom Lane wrote:
> I wrote:
> > Currently looking through the rest of the patch. I'm wondering
> > about appendStringLiteral: maybe we should kill that entirely
> > in favor of using PQescapeStringConn? It's not nearly bright
> > enough about encoding for instance (and it *will* be used in
> > client-only encodings).
> We could make an appendStringLiteralConn, which would do this correctly
> for most of the utility programs. However there's a problem for
> pg_restore: it doesn't necessarily have a PGconn at all. (Consider
> the case of pg_restore producing text output.)
> It seems that the alternatives are to export PQescapeStringInternal
> from libpq, or to duplicate its functionality in appendStringLiteral.
> Don't much like either, but perhaps the second is less bad. Any
I like the export idea myself. The less duplicate code the better.
Bruce Momjian http://candle.pha.pa.us
+ If your life is a hard drive, Christ can be your backup. +
In response to
pgsql-hackers by date
|Next:||From: Bruce Momjian||Date: 2006-05-28 03:15:17|
|Subject: Re: Better to dump tabs as tabs, or \t?|
|Previous:||From: Bruce Momjian||Date: 2006-05-28 02:42:11|
|Subject: Re: error in compilation!|