Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling
Date: 2006-05-15 08:28:23
Message-ID: 20060515082823.GA18700@svana.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Mon, May 15, 2006 at 12:09:37AM -0500, Jim C. Nasby wrote:
> On Fri, May 12, 2006 at 12:22:54PM +0200, Martijn van Oosterhout wrote:
> > A #define is doable, though messy. The code isn't all that long anyway
> > so a few #ifdefs might make it confusing. But I'll see what I can do.
> 
> If it proves messy, it's probably not worth doing. Presumably anyone
> able to tweak a #define could probably apply a patch as well. If you are
> going to go through the effort it probably makes the most sense to just
> add the remaining syntax to make it dynamic.

Making it configurable via a GUC would be much easier than making ik
optional at compile time because then you just need to skip the tests
for 'to sample or not'. To make it optional at compile time you'd need
to actually take out all the code relating to sampling.

Maybe:

enable_explain_sample (default: yes)

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

pgsql-hackers by date

Next:From: Mark CampbellDate: 2006-05-15 12:40:30
Subject: Re: Compiling on 8.1.3 on Openserver 5.05
Previous:From: Thomas HallgrenDate: 2006-05-15 05:25:10
Subject: Re: Fwd: [pgsql-hackers-win32] Build with Visual Studio

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-05-15 15:37:46
Subject: Re: [PATCH] Warning about configure args (weaker version)
Previous:From: Jim C. NasbyDate: 2006-05-15 05:09:37
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group