Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

From: "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling
Date: 2006-05-15 05:09:37
Message-ID: 20060515050937.GA6201@pervasive.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Fri, May 12, 2006 at 12:22:54PM +0200, Martijn van Oosterhout wrote:
> > > - I also didn't make it optional. I'm unsure about whether it should be
> > > optional or not, given the number of cases where it will make a
> > > difference to be very few.
> > 
> > The real question is how important it is to have the real data in the
> > cases where it would make a difference, and I suspect we can't answer
> > that until this is out in the field. It *might* be worth a #define or
> > some other way to disable it that doesn't require patching code, but
> > probably not.
> 
> A #define is doable, though messy. The code isn't all that long anyway
> so a few #ifdefs might make it confusing. But I'll see what I can do.

If it proves messy, it's probably not worth doing. Presumably anyone
able to tweak a #define could probably apply a patch as well. If you are
going to go through the effort it probably makes the most sense to just
add the remaining syntax to make it dynamic.
-- 
Jim C. Nasby, Sr. Engineering Consultant      jnasby(at)pervasive(dot)com
Pervasive Software      http://pervasive.com    work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf       cell: 512-569-9461

In response to

Responses

pgsql-hackers by date

Next:From: Thomas HallgrenDate: 2006-05-15 05:25:10
Subject: Re: Fwd: [pgsql-hackers-win32] Build with Visual Studio
Previous:From: Gurjeet SinghDate: 2006-05-15 03:51:28
Subject: Re: Fwd: [pgsql-hackers-win32] Build with Visual Studio & MSVC

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2006-05-15 08:28:23
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling
Previous:From: Martijn van OosterhoutDate: 2006-05-14 21:03:03
Subject: [PATCH] Warning about configure args (weaker version)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group