Re: [BUGS] BUG #2401: spinlocks not available on amd64

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
Date: 2006-04-28 04:34:05
Message-ID: 200604280434.k3S4Y5q20868@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Kris Jurka wrote:
> Bruce Momjian wrote:
> > Great, changes attached and applied. I removed the solaris_i386 and
> > solaris_x86_64.s files and made just one solaris_x86.s. I updated the
> > build system to use the new file, updated the macros, and added some
> > documentation on the approach. Thanks.
> >
> > Would you test current CVS to make sure it still works properly? Thanks.
> >
>
> The patch adds an extra else in src/template/solaris that means the
> assembly file is not properly picked up.

Sorry, removed.

> Also the claim that Sun's cc understands C preprocessor doesn't hold
> true for me:
>
> /usr/local/SUNWspro/bin/cc -Xa -v -DSUNOS4_CC -g -c tas.s
> Assembler: tas.s
> "tas.s", line 9 : Illegal mnemonic
> "tas.s", line 9 : Syntax error
> "tas.s", line 9 : Illegal mnemonic
> "tas.s", line 9 : Illegal mnemonic
>
> This is with cc -V
> cc: Sun WorkShop 6 update 2 C 5.3 Patch 111680-09 2003/05/18

Interesting. It is probably possible to just run the *.s file through
cpp and compile the result, or just go back to having two files.

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Platonov 2006-04-28 07:55:50 BUG #2413: connection refused 0274D/10061
Previous Message Sidar Lopez Cruz 2006-04-28 04:27:27 BUG #2412: Foreing key accept nulls

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-04-28 17:09:16 pgsql: Modify Solaris compiler build rules to use the cpp preprocessor,
Previous Message Kris Jurka 2006-04-28 04:25:48 Re: [BUGS] BUG #2401: spinlocks not available on amd64