Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Enhanced containment selectivity function

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Matteo Beccati <php(at)beccati(dot)com>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Enhanced containment selectivity function
Date: 2006-04-26 20:26:53
Message-ID: 200604262026.k3QKQr301927@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Cleaned-up patch attached and applied.
> 
> Please revert this patch.  This has not been updated to satisfy the
> previous agreement about how it should work.  It is completely
> inappropriate to be dropping code that's specific to one contrib module
> into the core selfuncs.c file.  What we had agreed to do was look at
> exporting some of the currently-static functions in selfuncs.c so that
> contrib modules could make use of them from outside the core --- but
> this patch doesn't do that.

OK, reverted, but I saw it using contsel() so I figured we were allowing
it, but I see contsel() is used by our "box", so ltree was just using
something that was already there.  Let me see if I can break out the new
selectivity function into /contrib.

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-04-26 20:33:06
Subject: Re: [HACKERS] Enhanced containment selectivity function
Previous:From: Tom LaneDate: 2006-04-26 19:12:46
Subject: Re: [HACKERS] Enhanced containment selectivity function

pgsql-patches by date

Next:From: Tom LaneDate: 2006-04-26 20:33:06
Subject: Re: [HACKERS] Enhanced containment selectivity function
Previous:From: Tom LaneDate: 2006-04-26 19:12:46
Subject: Re: [HACKERS] Enhanced containment selectivity function

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group