Here's some patches to clear up some of the most obvious problems with
ECPG. This is just scratching the surface, but it's good to start
Strange assumption about var. The rest of the code in the function
assumes var will not be NULL, yet this one line does not.
Assumption that PQresultErrorField will never return NULL.
The code allows con to be NULL, yet if it is, this line will segfault.
Move the PGTYPESnumeric_free outside the loop to avoid the double free
A patch which add a "make check" to the ecpg/test directory. I don't
expect this to be committed to CVS, but it's provided as an example of
the tests the above patches pass.
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2006-04-23 23:41:16|
|Subject: Re: Building with Visual C++ |
|Previous:||From: Magnus Hagander||Date: 2006-04-23 20:10:54|
|Subject: Building with Visual C++|