Skip site navigation (1) Skip section navigation (2)

Re: WIP: splitting BLCKSZ

From: Mark Wong <markw(at)osdl(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: WIP: splitting BLCKSZ
Date: 2006-03-23 19:27:45
Message-ID: 200603231925.k2NJPmDZ012393@smtp.osdl.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Wed, 22 Mar 2006 14:19:48 -0500
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Mark Wong <markw(at)osdl(dot)org> writes:
> > I proposed to explore splitting BLCKSZ into separate values for logging
> > and data to see if there might be anything to gain:
> > 	http://archives.postgresql.org/pgsql-hackers/2006-03/msg00745.php
> > My first pass was to do more or less a search and replace (attached) and
> > I am already running into trouble with a 'make check' (below).  I'm
> > guessing that when initdb is run, I'm not properly saving the values
> > that I've defined for DATA_BLCKSZ and possibly LOG_BLCKSZ.
> 
> I'd suggest leaving BLCKSZ as-is and inventing XLOG_BLCKSZ to be used
> only within the WAL code; should make for a *far* smaller patch.
> Offhand I don't think that anything except xlog.c knows the WAL block
> size --- it should be fairly closely associated with dependencies on
> XLOG_SEG_SIZE, if you are looking for something to grep for.

Ok, I have attached something much smaller.  Appears to pass a 'make
check' but I'll keep going to make sure it's really correct and works.

Thanks,
Mark

Attachment: pgsql-c-xlog_blcksz.patch
Description: text/x-patch (26.4 KB)

In response to

Responses

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2006-03-23 19:47:04
Subject: Re: Where does the time go?
Previous:From: Kevin GrittnerDate: 2006-03-23 19:16:33
Subject: Re: predicate locking knowledge

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group