Skip site navigation (1) Skip section navigation (2)

Re: fix of some issues with multi-line query editing

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
Cc: pgsql-patches(at)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, alvherre(at)commandprompt(dot)com
Subject: Re: fix of some issues with multi-line query editing
Date: 2006-03-21 13:38:27
Message-ID: 200603211338.k2LDcRF14008@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Sergey E. Koposov wrote:
> Fix of several issues:
> 
> 1) Fix the problems with the \s command. 
> When the saveHistory is executed by the \s command we must not do the 
> conversion \n -> \x01  (per 
> http://archives.postgresql.org/pgsql-hackers/2006-03/msg00317.php )
> 
> 2) Fix the handling of Ctrl+C
> 
> Now when you do
> wsdb=# select 'your long query here '
> wsdb-# 
> and press afterwards the CtrlC the line "select 'your long query here '" 
> will be in the history
> 
> (partly per 
> http://archives.postgresql.org/pgsql-hackers/2006-03/msg00297.php )
> 
> 3) Fix the handling of commands with not closed brackets, quotes, double 
> quotes. (now those commands are not splitted in parts...)
> 
> 4) Fix the behaviour when SINGLELINE mode is used. (before it was almost 
> broken ;( 

Great.  Patch applied.  I had to adjust your patch around changes made
to put backslash commands embedded in queries to the top of the history.

Updated patch attached.

-- 
  Bruce Momjian   http://candle.pha.pa.us
  SRA OSS, Inc.   http://www.sraoss.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-03-21 13:43:08
Subject: Re: Improve psql's handling of multi-line queries
Previous:From: Jim C. NasbyDate: 2006-03-21 12:22:11
Subject: WAL logging of SELECT ... INTO command

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group