Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch Submission Guidelines

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch Submission Guidelines
Date: 2006-02-24 17:18:22
Message-ID: 200602241718.k1OHIMS13586@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> > On Thursday 16 February 2006 00:27, Tom Lane wrote:
> >> * avoid unnecessary whitespace changes.  They just distract the
> >> reviewer, and your formatting changes will probably not survive
> >> the next pgindent run anyway.
> 
> > would diff -c --ignore-space-change be better?
> 
> Hmm.  Not sure --- there are situations where whitespace *does* matter,
> so having that as a blanket policy doesn't seem wise.  Also I'm worried
> that a diff made this way would confuse patch (for instance, because
> line numbers following an omitted whitespace change wouldn't match up).
> Probably best not to go there, but just focus on the point about keeping
> the patch readable.

Agreed.  It isn't that we don't want whitespace changes, just that we
don't want insignificant whitespace changes.

-- 
  Bruce Momjian   http://candle.pha.pa.us
  SRA OSS, Inc.   http://www.sraoss.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2006-02-24 17:18:57
Subject: Re: fsutil ideas
Previous:From: Bruce MomjianDate: 2006-02-24 17:16:58
Subject: Re: [HACKERS] Patch Submission Guidelines

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-02-24 19:57:19
Subject: Re: how solve diff of API counstruct_md_array between
Previous:From: Bruce MomjianDate: 2006-02-24 17:16:58
Subject: Re: [HACKERS] Patch Submission Guidelines

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group