Skip site navigation (1) Skip section navigation (2)

pgsql: I've created a new shared catalog table pg_shdescription to store

From: momjian(at)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: I've created a new shared catalog table pg_shdescription to store
Date: 2006-02-12 03:22:21
Message-ID: 20060212032221.AEAAC9DCA8C@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
I've created a new shared catalog table pg_shdescription to store
comments on cluster global objects like databases, tablespaces, and
roles.

It touches a lot of places, but not much in the way of big changes.  The
only design decision I made was to duplicate the query and manipulation
functions rather than to try and have them handle both shared and local
comments.  I believe this is simpler for the code and not an issue for
callers because they know what type of object they are dealing with. 
This has resulted in a shobj_description function analagous to
obj_description and backend functions [Create/Delete]SharedComments
mirroring the existing [Create/Delete]Comments functions.

pg_shdescription.h goes into src/include/catalog/

Kris Jurka

Modified Files:
--------------
    pgsql/doc/src/sgml:
        catalogs.sgml (r2.119 -> r2.120)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/catalogs.sgml.diff?r1=2.119&r2=2.120)
        func.sgml (r1.304 -> r1.305)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml.diff?r1=1.304&r2=1.305)
    pgsql/doc/src/sgml/ref:
        comment.sgml (r1.29 -> r1.30)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/comment.sgml.diff?r1=1.29&r2=1.30)
    pgsql/src/backend/catalog:
        Makefile (r1.58 -> r1.59)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/Makefile.diff?r1=1.58&r2=1.59)
        genbki.sh (r1.37 -> r1.38)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/genbki.sh.diff?r1=1.37&r2=1.38)
    pgsql/src/backend/commands:
        comment.c (r1.85 -> r1.86)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/comment.c.diff?r1=1.85&r2=1.86)
        dbcommands.c (r1.175 -> r1.176)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/dbcommands.c.diff?r1=1.175&r2=1.176)
        tablespace.c (r1.29 -> r1.30)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablespace.c.diff?r1=1.29&r2=1.30)
        user.c (r1.168 -> r1.169)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/user.c.diff?r1=1.168&r2=1.169)
    pgsql/src/backend/parser:
        gram.y (r2.527 -> r2.528)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/gram.y.diff?r1=2.527&r2=2.528)
    pgsql/src/bin/initdb:
        initdb.c (r1.108 -> r1.109)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/initdb.c.diff?r1=1.108&r2=1.109)
    pgsql/src/bin/pg_dump:
        pg_dump.c (r1.427 -> r1.428)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.427&r2=1.428)
        pg_dumpall.c (r1.69 -> r1.70)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c.diff?r1=1.69&r2=1.70)
    pgsql/src/bin/psql:
        command.c (r1.159 -> r1.160)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/command.c.diff?r1=1.159&r2=1.160)
        describe.c (r1.130 -> r1.131)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c.diff?r1=1.130&r2=1.131)
        describe.h (r1.29 -> r1.30)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.h.diff?r1=1.29&r2=1.30)
        tab-complete.c (r1.145 -> r1.146)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/tab-complete.c.diff?r1=1.145&r2=1.146)
    pgsql/src/include:
        postgres.h (r1.72 -> r1.73)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/postgres.h.diff?r1=1.72&r2=1.73)
    pgsql/src/include/catalog:
        catversion.h (r1.314 -> r1.315)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h.diff?r1=1.314&r2=1.315)
        indexing.h (r1.92 -> r1.93)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/indexing.h.diff?r1=1.92&r2=1.93)
        pg_database.h (r1.38 -> r1.39)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_database.h.diff?r1=1.38&r2=1.39)
        pg_proc.h (r1.396 -> r1.397)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h.diff?r1=1.396&r2=1.397)
    pgsql/src/include/commands:
        comment.h (r1.16 -> r1.17)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/comment.h.diff?r1=1.16&r2=1.17)
    pgsql/src/test/regress/expected:
        sanity_check.out (r1.29 -> r1.30)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/sanity_check.out.diff?r1=1.29&r2=1.30)

Added Files:
-----------
    pgsql/src/include/catalog:
        pg_shdescription.h (r1.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_shdescription.h?rev=1.1&content-type=text/x-cvsweb-markup)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2006-02-12 03:23:55
Subject: pgsql: New Directory
Previous:From: Tom LaneDate: 2006-02-12 03:10:04
Subject: pgsql: Undo changes of trailing space in recently-committed expected

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group