| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Kris Jurka <books(at)ejurka(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align |
| Date: | 2006-02-10 21:49:12 |
| Message-ID: | 20060210214912.GG576@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-patches |
On Fri, Feb 10, 2006 at 02:13:26PM -0500, Tom Lane wrote:
> For the most part we say "char" where we can and "unsigned char" only
> where it really matters, which is mostly inside code that's
> encoding-aware anyway.
Well, I've done this and avoided changing any public interfaces. ie the
libpq interface remains unsigned, as does the psql formatting code, but
the printTable stuff only is for the parts that actually do
formatting...
Patch attached. Passes -pedantic on gcc 3.3.5
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
| Attachment | Content-Type | Size |
|---|---|---|
| signed.diff | text/plain | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-02-10 21:52:22 | pgsql: Check that SID is enabled while checking for Windows admin |
| Previous Message | Tom Lane | 2006-02-10 19:13:26 | Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-02-10 22:06:50 | Re: Fix for running from admin account on win32 |
| Previous Message | Simon Riggs | 2006-02-10 21:03:18 | Re: Scrollable cursors and Sort performance |