Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: kleptog(at)svana(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align
Date: 2006-02-10 15:48:55
Message-ID: 200602101548.k1AFmtM09788@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
OK, I have applied your patch to psql and Teodor has adjusted the
tsearch2 expected results.  I can't seem to run pgcrypto without getting
PRNG errors, so I expect my SSL is too old.  Would you send me your
pgcrypto/regression.diff?  Thanks.

---------------------------------------------------------------------------

Kris Jurka wrote:
> 
> 
> On Thu, 9 Feb 2006, Bruce Momjian wrote:
> 
> > Log Message:
> > -----------
> > Allow psql multi-line column values to align in the proper columns
> >
> 
> There is a problem with this on AIX.
> 
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=asp&dt=2006-02-10%2006:23:00
> 
> For tables that have no columns AIX thinks it has an out of memory error. 
> src/bin/psql/print.c:pg_local_calloc bails out if calloc returns NULL.  I 
> believe AIX is returning NULL for calloc with a count of zero.  Efforts 
> are made not to call pg_local_calloc with a count of zero, but one place 
> is missed, the attached patch fixes that.
> 
> Additionally there are a whole lot of of signedness warnings introduced 
> which I've attached.
> 
> Kris Jurka

Content-Description: 

[ Attachment, skipping... ]

Content-Description: 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>        message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2006-02-10 15:57:58
Subject: pgsql: Clean up some signedness warnings.
Previous:From: Bruce MomjianDate: 2006-02-10 15:48:05
Subject: pgsql: Fix psql after newline patch for calloc(0).

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-02-10 15:54:36
Subject: Re: FW: PGBuildfarm member snake Branch HEAD Status changed
Previous:From: Dave PageDate: 2006-02-10 15:14:13
Subject: Re: FW: PGBuildfarm member snake Branch HEAD Status changed from OK to ContribCheck failure

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group