Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pgxs/windows

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgxs/windows
Date: 2006-01-19 20:45:45
Message-ID: 200601192045.k0JKjje15085@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > The difference between Magnus's and Andrew's is
> > that Magnus used MODULE_big (which means create a shared library), while
> > Andrew used MODULES.  So, Magnus's only worked because he was creating a
> > DLL and that brought in the -L from MODULE_big.
> 
> Ah, good catch.
> 
> > I have applied the following patch to change /bin to /lib for Cygwin and
> > Win32.
> 
> What about the question of whether $(DESTDIR) belongs there or not?
> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
> because that's only for install-time stuff.

I considered that a separate issue and didn't explore it, but I think
you are right that $(DESTDIR) makes no sense so I will remove it.

Patch attached.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-01-19 20:46:28
Subject: Re: Bogus path in postmaster.opts
Previous:From: Tom LaneDate: 2006-01-19 20:34:56
Subject: Re: Indexes vs. cache flushes

pgsql-patches by date

Next:From: Tom LaneDate: 2006-01-19 20:48:03
Subject: Re: Uninstall scripts for contrib
Previous:From: Tom LaneDate: 2006-01-19 20:33:25
Subject: Re: [HACKERS] pgxs/windows

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group