Skip site navigation (1) Skip section navigation (2)

Re: TODO item: list prepared queries

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joachim Wieland <joe(at)mcknight(dot)de>, pgsql-patches(at)postgresql(dot)org
Subject: Re: TODO item: list prepared queries
Date: 2005-12-31 16:50:46
Message-ID: 200512311650.jBVGokx22490@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway wrote:
> Bruce Momjian wrote:
> > I have applied the following patch to CVS HEAD to mark client-side
> > prepare/bind/execute statements with "[client]" so they can be easily
> > distinguished from SQL commands.
> 
> There is no such thing as a "client-side prepare/bind/execute" 
> statement. The distinction is between SQL-level and protocol-level 
> prepared queries. "[client]" seems wrong; perhaps "[protocol]" could be 
> used instead?

Agreed.  I never liked "client" either.  It got me confused.  I have
changed it to protocol;  patch attached.

> (I'm not thrilled by the idea of prefixing the statement log with 
> "[...]" in any case: it makes it more difficult to determine the actual 
> query string submitted by the user. However I can't see a better 
> alternative...)

Yep.

> > I hesitate to apply this logging change to 8.1.X.
> 
> I don't see any reason to do that -- this is not a bug fix. Furthermore, 
> there are backward-compatibility concerns.

Right.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2005-12-31 19:43:26
Subject: Re: TODO item: list prepared queries
Previous:From: Magnus HaganderDate: 2005-12-31 16:18:29
Subject: LDAP auth

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group