Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Luke Lonergan <llonergan(at)greenplum(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Ben Gould <ben(dot)gould(at)free(dot)fr>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of
Date: 2005-12-28 03:27:57
Message-ID: 200512280327.jBS3RvC27705@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
Luke Lonergan wrote:
> Bruce,
> 
> On 12/27/05 10:20 AM, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> 
> > OK, original patch applied to HEAD and smaller version to 8.1.X, and
> > regression test added, now attached.
> 
> Great, good catch.
> 
> Have you tested performance, before and after?
> 
> The only good way to test performance is using a fast enough I/O subsystem
> that you are CPU-bound, which means >60MB/s of write speed.
> 
> I'd be happy to get you an account on one.

I don't need to test performance because it is the same code, just with
macros and the two functions merged.  I do have an optimization for that
loop but I saw no improvement so I didn't apply it.  It was basically to
advance the pointer in a tight look just checking for \r, \n, and \\,
but it seems the larger loop isn't much slower than a tight one.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2005-12-28 03:46:28
Subject: Re: BUG #2129: dblink problem
Previous:From: Luke LonerganDate: 2005-12-28 03:25:53
Subject: Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-12-28 03:43:06
Subject: Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of
Previous:From: Luke LonerganDate: 2005-12-28 03:25:53
Subject: Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group