From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Ben Gould <ben(dot)gould(at)free(dot)fr>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of copy marker |
Date: | 2005-12-27 17:49:13 |
Message-ID: | 200512271749.jBRHnDG07431@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-patches |
Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> > The big problem is that \. is also a valid
> >CSV data value (though not a valid non-CSV data value). So, the
> >solution we came up with was to require \. to appear alone on a line in
> >CSV mode for it to be treated as end-of-copy.
> >
>
> According to the docs, that's the way to specify EOD in both text and
> CSV mode:
>
> End of data can be represented by a single line containing just
> backslash-period.
Right, but in non-CSV mode, we allow \. at the end of any line because
it is unique so I kept that behavior. That is not documented however.
> Your analysis regarding line_buf.len seems correct.
>
> We probably should have a regression test with \. in a CSV field.
Agreed. My test for CSV was simple, just try loading:
x\.
x\.b
\.c
all should load literally, but they fail.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-12-27 18:20:58 | Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of copy marker |
Previous Message | Bruce Momjian | 2005-12-27 17:36:38 | Re: BUG #2128: unable to install win32 version of pgsql 8.1.1 |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-12-27 18:20:58 | Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of copy marker |
Previous Message | Bruce Momjian | 2005-12-27 17:45:07 | Re: [HACKERS] Online backup vs Continuous backup |