Skip site navigation (1) Skip section navigation (2)

Re: patch for cleanup protocol

From: Ludek Finstrle <luf(at)pzkagis(dot)cz>
To: Tomas Skäre <tomas(at)nocrew(dot)org>
Cc: pgsql-odbc(at)postgresql(dot)org
Subject: Re: patch for cleanup protocol
Date: 2005-12-20 10:23:20
Message-ID: 20051220102320.GA22210@soptik.pzkagis.cz (view raw or flat)
Thread:
Lists: pgsql-odbc
> I'm not qualified to tell if the changes are correct, but I just
> noticed this one thing:
> 
> >   				";%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%s;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d",
> >   				INI_READONLY,
> >   				ci->onlyread,
> > - 				INI_PROTOCOL,
> > - 				ci->protocol,

...

> If you remove these arguments, you have to remove the corresponding
> (second from start) "%s=%s" pair from the format string, otherwise
> it'll use the wrong variables for the %d's further on.

Yes. Very good point. Thank you Tomas.

> Looks fine to me (haven't tested it though) - however, please add a

I test it. It works good for me. But there can be sill bug (I hope there
is no bug).

> prominent note in dlg_specific.c to remind us not to reuse old parameter
> names/aliases in the future unless it's for the same purpose they were
> originally used for, and list those names of course (well, name in this
> first case).

I try add some note but I don't know if it fits you expectation. If it's
not good for you please change it and send me patch which solve it.

Second try ... (I break in this two advices)
I forgot. I made this patch againist CVS head.

Please review and comment

Luf

In response to

pgsql-odbc by date

Next:From: Dave PageDate: 2005-12-20 10:40:31
Subject: Re: patch for cleanup protocol
Previous:From: zhaoxinDate: 2005-12-20 10:17:55
Subject: ODBC ErrorCode issue

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group