| From: | Ludek Finstrle <luf(at)pzkagis(dot)cz> |
|---|---|
| To: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
| Cc: | pgsql-odbc(at)postgresql(dot)org |
| Subject: | Re: More strict bind param count checking |
| Date: | 2005-12-17 20:50:47 |
| Message-ID: | 20051217205047.GA28826@soptik.pzkagis.cz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-odbc |
> Looks pretty good to me.
Very good.
> It's more safe to adjust the param_count in case of apdopts->allocated <
> param_count.
Thanks fot pointing it.
> Also it's safe to change the following code in PGAPI_ParamData.
>
> /* At least 1 data at execution parameter, so Fill in the token value */
> for (; i < apdopts->allocated; i++)
I implement it both. New patch attached.
I also change older test for param number from == to >= and
comment out some not used code.
Thank you very much again Hiroshi
Luf
P.S. Dave can I commit it if there it no negative answer?
| Attachment | Content-Type | Size |
|---|---|---|
| psqlodbc-limit_bind_param.diff | text/plain | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | noreply | 2005-12-17 22:54:10 | [ psqlodbc-Bugs-1000490 ] cannot connect |
| Previous Message | Jim C. Nasby | 2005-12-16 21:51:25 | Re: Does postgresql-odbc work on 64-bit platforms? |