Skip site navigation (1) Skip section navigation (2)

Re: More strict bind param count checking

From: Ludek Finstrle <luf(at)pzkagis(dot)cz>
To: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: pgsql-odbc(at)postgresql(dot)org
Subject: Re: More strict bind param count checking
Date: 2005-12-17 20:50:47
Message-ID: 20051217205047.GA28826@soptik.pzkagis.cz (view raw or flat)
Thread:
Lists: pgsql-odbc
> Looks pretty good to me.

Very good.

> It's more safe to adjust the param_count in case of apdopts->allocated <
> param_count.

Thanks fot pointing it.

> Also it's safe to change the following code in PGAPI_ParamData.
> 
> /* At least 1 data at execution parameter, so Fill in the token value */
>         for (; i < apdopts->allocated; i++)

I implement it both. New patch attached.
I also change older test for param number from == to >= and
comment out some not used code.

Thank you very much again Hiroshi

Luf

P.S. Dave can I commit it if there it no negative answer?

In response to

pgsql-odbc by date

Next:From: noreplyDate: 2005-12-17 22:54:10
Subject: [ psqlodbc-Bugs-1000490 ] cannot connect
Previous:From: Jim C. NasbyDate: 2005-12-16 21:51:25
Subject: Re: Does postgresql-odbc work on 64-bit platforms?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group