| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: A couple of tiny performance hacks in _bt_step(). |
| Date: | 2005-12-07 18:03:48 |
| Message-ID: | 20051207180348.DB1E39DCABF@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
A couple of tiny performance hacks in _bt_step(). Remove PageIsEmpty
checks, which were once needed because PageGetMaxOffsetNumber would
fail on empty pages, but are now just redundant. Also, don't set up
local variables that aren't needed in the fast path --- most of the
time, we only need to advance offnum and not step across a page boundary.
Motivated by noticing _bt_step at the top of OProfile profile for a
pgbench run.
Modified Files:
--------------
pgsql/src/backend/access/nbtree:
nbtsearch.c (r1.97 -> r1.98)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/nbtree/nbtsearch.c.diff?r1=1.97&r2=1.98)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-12-07 19:37:54 | pgsql: Push the responsibility for handling ignore_killed_tuples down |
| Previous Message | Bruce Momjian | 2005-12-07 17:29:14 | pgsql: Update: < at initdb time or optionally later. |