Two fixes from Tom Lan. See the posting "[PATCHES] A couple of
proposed pgbench changes" on 2005/11/29 for more details.
The change at line 490 updates doCustom's local variable "commands"
after selecting a new file (command sequence). I think that the
existing coding will cause the thing to use the first command of the
old sequence in the remainder of the routine, which would be a bug.
I have not tried to set up a test case to prove it, though.
The other two changes cause doCustom to loop after processing a
meta-command. This might be a bit controversial, but as the code
is currently written, each meta-command "costs" one cycle of the
outer select() loop. Thus, for example, with the default TPC-B script,
once a backend returns "COMMIT" it will not receive a new command
until four cycles of issuing commands to other backends have elapsed.
(You can see this very easily by strace'ing pgbench under load.)
pgbench.c (r184.108.40.206 -> r220.127.116.11)
pgsql-committers by date
|Next:||From: James William Pye||Date: 2005-12-04 03:26:18|
|Subject: python - be: Use regprocedurein for string based function lookups.|
|Previous:||From: James William Pye||Date: 2005-12-04 00:31:37|
|Subject: python - be: Update the prototype.|