Skip site navigation (1) Skip section navigation (2)

Re: BUG #2056: to_char no long takes time as input?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Nick Addington <adding(at)math(dot)wisc(dot)edu>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #2056: to_char no long takes time as input?
Date: 2005-12-02 04:02:38
Message-ID: 200512020402.jB242cs17780@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
Oh, one more thing.  With the new patch I just posted, '0 hours' and
'HH' returns 12:

	test=> select to_char('0 hours'::interval, 'HH');
	 to_char
	---------
	 12
	(1 row)

Of course HH24 works fine.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I see your issue with HH/HH24, but I wanted this to work:
> 
> > 	test=> select to_char('14 hours'::interval, 'HH');
> > 	 to_char
> > 	---------
> > 	 14
> > 	(1 row)
> 
> > With the HH/HH24 change that is going to return 2.  Do interval folks
> > know they would have to use HH24 for intervals?
> 
> Dunno if they know it, but they always had to do it that way before 8.1,
> so it's not a change to require it.  I get this in everything back to
> 7.2:
> 
> regression=# select to_char('14 hours'::interval, 'HH');
>  to_char
> ---------
>  02
> (1 row)
> 
> regression=# select to_char('14 hours'::interval, 'HH24');
>  to_char
> ---------
>  14
> (1 row)
> 
> and I don't see anything especially wrong with that behavior, as long as
> it's documented.
> 
> > Should we subtract 12 only if the time is < 24.  That also seems
> > strange.  Also, a zero hour interval to HH would return 12, not 0.
> 
> Offhand I'd vote for making the HH code use a "mod 12" calculation,
> and making AM/PM depend on the value "mod 24".  This gives at least a
> slightly sane behavior for intervals > 24 hours.
> 
> 			regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
> 
>                http://archives.postgresql.org
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2005-12-02 04:06:50
Subject: Re: BUG #2056: to_char no long takes time as input?
Previous:From: Bruce MomjianDate: 2005-12-02 04:01:01
Subject: Re: [BUGS] BUG #2056: to_char no long takes time as input?

pgsql-patches by date

Next:From: Tom LaneDate: 2005-12-02 04:03:52
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Bruce MomjianDate: 2005-12-02 04:01:01
Subject: Re: [BUGS] BUG #2056: to_char no long takes time as input?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group